arch/arm/src/stm32h7: unassigned ret variable in SIOCSCANBITRATE. #16224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem was introduced in apache#16199 Signed-off-by: Carlos Sanchez <[email protected]>
github-actions
bot
added
Arch: arm
xiaoxiang781216
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This problem was introduced in #16199
In that PR, the assignment of "ret" variable was removed so now this variable might be used in uninitialized status when ioctl(...SIOCSCANBITRATE...) is called.
Impact
ioctl calls for CAN interfaces on stm32h7 can return as failed when they effectively succeeded.
Testing
The error was found due to a compiler warning after the previous PR was already merged.